[PATCH 1/3] dt-bindings: aspeed: Add silicon id node to SCU

[Joel Stanley]

On Wed, 16 Sep 2020 at 23:45, Andrew Jeffery <andrew at aj.id.au> wrote:
>
>
>
> On Wed, 16 Sep 2020, at 18:17, Joel Stanley wrote:
> > Different Aspeed families have various unique hardware silicon
> > identifiers within the SoC.
> >
> > Signed-off-by: Joel Stanley <joel at jms.id.au>
> > ---
> >  .../devicetree/bindings/mfd/aspeed-scu.txt    | 23 +++++++++++++++++++
> >  1 file changed, 23 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/aspeed-scu.txt
> > b/Documentation/devicetree/bindings/mfd/aspeed-scu.txt
> > index 4d92c0bb6687..fff3151f06ee 100644
> > --- a/Documentation/devicetree/bindings/mfd/aspeed-scu.txt
> > +++ b/Documentation/devicetree/bindings/mfd/aspeed-scu.txt
> > @@ -20,3 +20,26 @@ syscon: syscon at 1e6e2000 {
> >       #clock-cells = <1>;
> >       #reset-cells = <1>;
> >  };
> > +
> > +Silicon ID
> > +-----------------
> > +
> > +Families have unique hardware silicon identifiers within the SoC.
> > +
> > +Required properties:
> > +
> > + - compatible:               "aspeed,silicon-id" or:
> > +                     "aspeed,ast2400-silicon-id" or
> > +                     "aspeed,ast2501-silicon-id" or
>
> aspeed,ast2510-silicon-id

It was supposed to be 2500. Good catch.

>
> > +                     "aspeed,ast2600-silicon-id"
> > +
> > + - reg:                      offset and length of the silicon id information
> > +                     optionally, a second offset and length describes the unique chip id
>
> What about chips with multiple silicon ID regs? I guess we just pick a sensible
> one, though given recent events maybe we should make an explicit note for the
> 2600?

I will add a note saying the 2600 should be the unique one, not
useless backwards compatible one.

Cheers,

Joel