[PATCH 4/7] drivers: leds: Add the iEi WT61P803 PUZZLE LED driver
pavel at ucw.cz
Tue Sep 8 18:22:17 EDT 2020
> Add support for the iEi WT61P803 PUZZLE LED driver.
> Currently only the front panel power LED is supported.
> This driver depends on the iEi WT61P803 PUZZLE MFD driver.
> Signed-off-by: Luka Kovacic <luka.kovacic at sartura.hr>
> Cc: Luka Perkov <luka.perkov at sartura.hr>
> +#define CMD_CHAR(x) (char)(x)
Come on... no need to hide this in macro.
> *resp_buf = kmalloc(IEI_WT61P803_PUZZLE_BUF_SIZE, GFP_KERNEL); + +
AFAICT you'll happily dereference NULL when kmalloc fails.
If it is small, should you just put buffer on stack?
More information about the linux-arm-kernel