[PATCH] arm64: dts: marvell: espressobin: Add ethernet switch aliases
Andre Heider
a.heider at gmail.com
Mon Sep 7 13:44:19 EDT 2020
On 07/09/2020 19:42, Pali Rohár wrote:
> On Monday 07 September 2020 19:13:41 Andre Heider wrote:
>>> @@ -120,7 +124,7 @@
>>> #address-cells = <1>;
>>> #size-cells = <0>;
>>> - port at 0 {
>>> + switch0port0: port at 0 {
>>
>> This label is unused it seems.
>
> Yes, it is unused, but I defined labels for all ports so it would be
> clean that ports are indexed from zero and not from one. Also it looks
> inconsistent if some of DSA ports have labels and some does not.
Alright, sounds good:
Reviewed-by: Andre Heider <a.heider at gmail.com>
>
>>
>>> reg = <0>;
>>> label = "cpu";
>>> ethernet = <ð0>;
>>> @@ -131,19 +135,19 @@
>>> };
>>> };
>>> - port at 1 {
>>> + switch0port1: port at 1 {
>>> reg = <1>;
>>> label = "wan";
>>> phy-handle = <&switch0phy0>;
>>> };
>>> - port at 2 {
>>> + switch0port2: port at 2 {
>>> reg = <2>;
>>> label = "lan0";
>>> phy-handle = <&switch0phy1>;
>>> };
>>> - port at 3 {
>>> + switch0port3: port at 3 {
>>> reg = <3>;
>>> label = "lan1";
>>> phy-handle = <&switch0phy2>;
>>>
>>
More information about the linux-arm-kernel
mailing list