[PATCH 02/23] irqchip/rvic: Add support for untrusted interrupt allocation

[Jonathan Cameron]

On Thu,  3 Sep 2020 16:25:49 +0100
Marc Zyngier <maz at kernel.org> wrote:

> Signed-off-by: Marc Zyngier <maz at kernel.org>
Hi Marc,

One trivial comment inline.

> ---
>  drivers/irqchip/irq-rvic.c | 47 +++++++++++++++++++++++++++++++++++---
>  1 file changed, 44 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-rvic.c b/drivers/irqchip/irq-rvic.c
> index 6f37aa4318b6..2747a452202f 100644
> --- a/drivers/irqchip/irq-rvic.c
> +++ b/drivers/irqchip/irq-rvic.c
> @@ -37,6 +37,8 @@ static DEFINE_PER_CPU(unsigned long *, trusted_masked);
>  struct rvic_data {
>  	struct fwnode_handle	*fwnode;
>  	struct irq_domain	*domain;
> +	unsigned long 		*bitmap;
> +	struct mutex		lock;

Nitpick. Good to document the scope of that lock. It's obvious in this
patch but might not be 10 years down the line!

>  	unsigned int		nr_trusted;
>  	unsigned int		nr_untrusted;
>  };
...