[PATCH v2 3/3] arm64: stacktrace: Convert to ARCH_STACKWALK
Miroslav Benes
mbenes at suse.cz
Wed Sep 2 05:32:13 EDT 2020
Hi,
it could be a silly question, but better to ask...
> + if (regs)
> + start_backtrace(&frame, regs->regs[29], regs->pc);
> + else
> + start_backtrace(&frame, thread_saved_fp(task),
> + thread_saved_pc(task));
Would this also work for task == current? Given that the original code had
> - start_backtrace(&frame,
> - (unsigned long)__builtin_frame_address(0),
> - (unsigned long)__save_stack_trace);
for the case, which seems correct (but I don't know much about arm64 arch
in the kernel).
Otherwise, I did not spot anything suspicious or wrong.
Regards
Miroslav
More information about the linux-arm-kernel
mailing list