[PATCH v2 6/6] selftests: arm64: Add build and documentation for FP tests
Dave Martin
Dave.Martin at arm.com
Tue Sep 1 11:38:42 EDT 2020
On Wed, Aug 19, 2020 at 12:48:37PM +0100, Mark Brown wrote:
> Integrate the FP tests with the build system and add some documentation
> for the ones run outside the kselftest infrastructure. The content in
> the README was largely written by Dave Martin with edits by me.
Apologies, I never got around to looking at all this, though it seems
reasonable.
I don't know whether this is worth following up with a TODO?
Some things I was aware of:
* The sve-test/fpsimd-test programs contain a lot of common
boilerplate and could probably be merged together.
* A fair amount of the asm in sve-test/fpsimd-test could be converted
to C, with -fgeneral-regs-only. This would be helpful since the
code is highly unmaintainable in its current form (I know, I've
tried). Calling library functions would still be a problem, but we
might be able to lift a printf implementation and some basic syscall
wrappers from elsewhere rather than reimplementing everything from
scratch.
* The sve-stress/fpsimd-stress scripts could likewise be merged.
Also, doing the required process management from the shell seems a
doomed enterprise and it never really worked 100% right. Eventually
it might be worth rewriting a common test driver for these in a real
language.
* While the tests confirm that basic aspects of the SVE support don't
explode, there is not a lot of checking that the kernel does the
_correct_ thing -- so there's scope for improvement here if somebody
gets around to it.
Cheers
---Dave
More information about the linux-arm-kernel
mailing list