[patch V2 00/18] mm/highmem: Preemptible variant of kmap_atomic & friends
Thomas Gleixner
tglx at linutronix.de
Thu Oct 29 18:18:06 EDT 2020
Following up to the discussion in:
https://lore.kernel.org/r/20200914204209.256266093@linutronix.de
and the initial version of this:
https://lore.kernel.org/r/20200919091751.011116649@linutronix.de
this series provides a preemptible variant of kmap_atomic & related
interfaces.
Now that the scheduler folks have wrapped their heads around the migration
disable scheduler woes, there is not a real reason anymore to confine
migration disabling to RT.
As expressed in the earlier discussion by graphics and crypto folks, there
is interest to get rid of their kmap_atomic* usage because they need only a
temporary stable map and not all the bells and whistels of kmap_atomic*.
This series provides kmap_local.* iomap_local variants which only disable
migration to keep the virtual mapping address stable accross preemption,
but do neither disable pagefaults nor preemption. The new functions can be
used in any context, but if used in atomic context the caller has to take
care of eventually disabling pagefaults.
This is achieved by:
- Removing the RT dependency from migrate_disable/enable()
- Consolidating all kmap atomic implementations in generic code
- Switching from per CPU storage of the kmap index to a per task storage
- Adding a pteval array to the per task storage which contains the ptevals
of the currently active temporary kmaps
- Adding context switch code which checks whether the outgoing or the
incoming task has active temporary kmaps. If so, the outgoing task's
kmaps are removed and the incoming task's kmaps are restored.
- Adding new interfaces k[un]map_temporary*() which are not disabling
preemption and can be called from any context (except NMI).
Contrary to kmap() which provides preemptible and "persistant" mappings,
these interfaces are meant to replace the temporary mappings provided by
kmap_atomic*() today.
This allows to get rid of conditional mapping choices and allows to have
preemptible short term mappings on 64bit which are today enforced to be
non-preemptible due to the highmem constraints. It clearly puts overhead on
the highmem users, but highmem is slow anyway.
This is not a wholesale conversion which makes kmap_atomic magically
preemptible because there might be usage sites which rely on the implicit
preempt disable. So this needs to be done on a case by case basis and the
call sites converted to kmap_temporary.
Note, that this is only lightly tested on X86 and completely untested on
all other architectures.
There is also a still to be investigated question from Linus on the initial
posting versus the per cpu / per task mapping stack depth which might need
to be made larger due to the ability to take page faults within a mapping
region.
Though I wanted to share the current state of affairs before investigating
that further. If there is consensus in going forward with this, I'll have a
deeper look into this issue.
The lot is available from
git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git highmem
It is based on Peter Zijlstras migrate disable branch which is close to be
merged into the tip tree, but still not finalized:
git://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git sched/migrate-disable
Changes vs. V1:
- Make it truly functional by depending on migrate disable/enable (Brown paperbag)
- Rename to kmap_local.* (Linus)
- Fix the sched in/out issue Linus pointed out
- Fix a few style issues (Christoph)
- Split a few things out into seperate patches to make review simpler
- Pick up acked/reviewed tags as appropriate
Thanks,
tglx
---
a/arch/arm/mm/highmem.c | 121 ------------------
a/arch/microblaze/mm/highmem.c | 78 ------------
a/arch/nds32/mm/highmem.c | 48 -------
a/arch/powerpc/mm/highmem.c | 67 ----------
a/arch/sparc/mm/highmem.c | 115 -----------------
arch/arc/Kconfig | 1
arch/arc/include/asm/highmem.h | 8 +
arch/arc/mm/highmem.c | 44 ------
arch/arm/Kconfig | 1
arch/arm/include/asm/highmem.h | 31 +++-
arch/arm/mm/Makefile | 1
arch/csky/Kconfig | 1
arch/csky/include/asm/highmem.h | 4
arch/csky/mm/highmem.c | 75 -----------
arch/microblaze/Kconfig | 1
arch/microblaze/include/asm/highmem.h | 6
arch/microblaze/mm/Makefile | 1
arch/microblaze/mm/init.c | 6
arch/mips/Kconfig | 1
arch/mips/include/asm/highmem.h | 4
arch/mips/mm/highmem.c | 77 ------------
arch/mips/mm/init.c | 3
arch/nds32/Kconfig.cpu | 1
arch/nds32/include/asm/highmem.h | 21 ++-
arch/nds32/mm/Makefile | 1
arch/powerpc/Kconfig | 1
arch/powerpc/include/asm/highmem.h | 6
arch/powerpc/mm/Makefile | 1
arch/powerpc/mm/mem.c | 7 -
arch/sparc/Kconfig | 1
arch/sparc/include/asm/highmem.h | 7 -
arch/sparc/mm/Makefile | 3
arch/sparc/mm/srmmu.c | 2
arch/x86/include/asm/fixmap.h | 1
arch/x86/include/asm/highmem.h | 12 +
arch/x86/include/asm/iomap.h | 13 --
arch/x86/mm/highmem_32.c | 59 ---------
arch/x86/mm/init_32.c | 15 --
arch/x86/mm/iomap_32.c | 57 --------
arch/xtensa/Kconfig | 1
arch/xtensa/include/asm/highmem.h | 9 +
arch/xtensa/mm/highmem.c | 44 ------
b/arch/x86/Kconfig | 3
include/linux/highmem.h | 203 ++++++++++++++++++++++---------
include/linux/io-mapping.h | 42 +++++-
include/linux/preempt.h | 38 -----
include/linux/sched.h | 11 +
kernel/entry/common.c | 2
kernel/fork.c | 1
kernel/sched/core.c | 30 +++-
kernel/sched/sched.h | 2
lib/smp_processor_id.c | 2
mm/Kconfig | 3
mm/highmem.c | 218 ++++++++++++++++++++++++++++++++--
54 files changed, 542 insertions(+), 969 deletions(-)
More information about the linux-arm-kernel
mailing list