[PATCH 4/5] dt-bindings: arm: sunxi: add Elimo bindings

Maxime Ripard maxime at cerno.tech
Thu Oct 29 06:13:04 EDT 2020


Hi,

On Thu, Oct 29, 2020 at 02:19:59AM +0000, Matteo Scordino wrote:
> Document board compatible names for Elimo Engineering Impetus and Initium
> 
> Signed-off-by: Matteo Scordino <matteo.scordino at gmail.com>
> ---
>  Documentation/devicetree/bindings/arm/sunxi.yaml | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
> index 0f23133672a3..55405809ec91 100644
> --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
> +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
> @@ -898,3 +898,13 @@ properties:
>          items:
>            - const: xunlong,orangepi-zero-plus2-h3
>            - const: allwinner,sun8i-h3
> +
> +      - description: Elimo Engineering Impetus SoM
> +        items:
> +          - const: elimo,impetus
> +          - const: allwinner,sun8i-s3
> +
> +      - description: Elimo Engineering Initium
> +        items:
> +          - const: elimo,initium
> +          - const: allwinner,sun8i-s3

This should be ordered alphabetically, and most importantly, must match
the ones you have in the DT.

Here, we have kind of a mess already: the Lichee Zero+ uses
,sipeed,lichee-zero-plus, sochip,s3, allwinner,sun8i-v3, while the
pinecube uses pine64,pinecube, allwinner,sun8i-s3

IIRC the S3 and V3 are pretty much the same SoCs, so the first one seems
to make more sense to me, but then we should fix the pinecube.

Maxime
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20201029/a35a508d/attachment.sig>


More information about the linux-arm-kernel mailing list