[PATCH V2 1/2] opp: Allow dev_pm_opp_get_opp_table() to return -EPROBE_DEFER

Guenter Roeck linux at roeck-us.net
Wed Oct 28 13:29:08 EDT 2020


On Wed, Oct 28, 2020 at 09:36:37AM +0530, Viresh Kumar wrote:
> On 27-10-20, 15:24, Guenter Roeck wrote:
> > Trying again through different e-mail provider. My previous e-mail
> > got stuck in spam filters. Apologies if this is received multiple
> > times.
> 
> I received only once :)
> 

I think the original was tagged by gmail as spam because it had too many
recipients. It came back with lots of "rejected by recipient", but I think
they just do that to confuse spammers. So likely no one received it.

> > On Mon, Aug 24, 2020 at 02:39:32PM +0530, Viresh Kumar wrote:
> > > From: Stephan Gerhold <stephan at gerhold.net>
> > > 
> > [ ... ]
> 
> You removed way too much and this lost the context. Keeping the
> routine's prototype line would have been useful.
> 
Sorry, the original was a bit more complete.

> > >  
> > >  	opp_table = dev_pm_opp_get_opp_table(dev);
> > > -	if (!opp_table)
> > > -		return ERR_PTR(-ENOMEM);
> > > +	if (!IS_ERR(opp_table))
> > > +		return opp_table;
> > 
> > This should have been
> > 
> > 	if (IS_ERR(opp_table))
> > 		return opp_table;
> 
> I believe this is the delta from dev_pm_opp_register_set_opp_helper()
> ?
> 
Correct.

> A proper fix is already pushed in linux-next for this yesterday.
> 

Great, thanks. I didn't notice because yesterday's build didn't include
the fix, and starting today I dropped the one qemu boot test that reported
it (beaglexm) because that doesn't work anymore for other reasons (due to
commit fb2c599f056, more specifically).

Guenter



More information about the linux-arm-kernel mailing list