[PATCH 5/7] dt-bindings: ata: Update ahci bindings with possible per-port interrupts

Hans de Goede hdegoede at redhat.com
Tue Oct 27 10:25:41 EDT 2020


Hi,

On 10/7/20 5:45 PM, sven.auhagen at voleatech.de wrote:
> From: Miquel Raynal <miquel.raynal at bootlin.com>
> 
> Update bindings to reflect the fact that a SATA IP can either have:
> - only one interrupt: in this case an 'interrupts' property is
>   declared at the root of the node;
> or
> - each SATA port can have their own interrupt: in this case there is
>   one 'interrupts' property per port/sub-node and none at the root.
> 
> Signed-off-by: Miquel Raynal <miquel.raynal at bootlin.com>
> Reviewed-by: Rob Herring <robh at kernel.org>

Patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede at redhat.com>

Regards,

Hans

> ---
>  Documentation/devicetree/bindings/ata/ahci-platform.txt | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/ata/ahci-platform.txt b/Documentation/devicetree/bindings/ata/ahci-platform.txt
> index 77091a277642..83d715cbcecd 100644
> --- a/Documentation/devicetree/bindings/ata/ahci-platform.txt
> +++ b/Documentation/devicetree/bindings/ata/ahci-platform.txt
> @@ -49,6 +49,12 @@ And at least one of the following properties:
>  - phys		    : reference to the SATA PHY node
>  - target-supply     : regulator for SATA target power
>  
> +Sub-nodes optional properties:
> +- interrupts        : <interrupt mapping for SATA ports IRQ>, please
> +                      note that either the root SATA node has the
> +                      interrupts property, or there is one per SATA
> +                      port, but not both at the same time.
> +
>  Examples:
>          sata at ffe08000 {
>  		compatible = "snps,spear-ahci";
> 




More information about the linux-arm-kernel mailing list