答复: [PATCH -next] tty: serial: imx: remove unnecessary breaks

[zhangqilong]

Hello

> On Mon, Oct 26, 2020 at 08:51:42PM +0800, Zhang Qilong wrote:
> > The 'break' is not possoble to be reached
> s/possoble/possible/
> 
> > because of previous 'return', discard it.
> 
> Given that this such a patch was already sent a week ago[1], I wonder if there
> is a tool that complains here? If so, mentioning it in the commit log would be
> good.
> 
> Other than that I still think that there should be at least an empty line instead
> of the break, as I already wrote in reply to the first patch. And having said that I
> also don't think this is worth "fixing", seeing the break in a switch statement is
> good for human readers.
> 
> Best regards
> Uwe

I have seen that patch, thank you for nice reminding. It's not a tool tip. I find it
when reading that code. So sending the patch to optimize it. It also looks good
to keep 'break'.
Thanks, best wish to you!
Zhang Qilong

> 
> [1] https://lore.kernel.org/r/20201019175915.3718-1-trix@redhat.com
> --
> Pengutronix e.K.                           | Uwe Kleine-König
> |
> Industrial Linux Solutions                 | https://www.pengutronix.de/ |