[PATCH v2] PCI: mvebu: Fix duplicate resource requests

Jan Kundrát jan.kundrat at cesnet.cz
Mon Oct 26 12:42:20 EDT 2020


On pátek 23. října 2020 16:52:52 CEST, Rob Herring wrote:
> With commit 669cbc708122 ("PCI: Move DT resource setup into
> devm_pci_alloc_host_bridge()"), the DT 'ranges' is parsed and populated
> into resources when the host bridge is allocated. The resources are
> requested as well, but that happens a 2nd time for the mvebu driver in
> mvebu_pcie_parse_request_resources(). We should only be requesting the
> additional resources added in mvebu_pcie_parse_request_resources().
> These are not added by default because the use custom properties rather
> than standard DT address translation.
>
> Also, the bus ranges was also populated by default, so we can remove
> it from mvebu_pci_host_probe().
>
> Fixes: 669cbc708122 ("PCI: Move DT resource setup into 
> devm_pci_alloc_host_bridge()")
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=209729
> Reported-by: vtolkm at googlemail.com
> Cc: Thomas Petazzoni <thomas.petazzoni at bootlin.com>
> Cc: Jason Cooper <jason at lakedaemon.net>
> Cc: Lorenzo Pieralisi <lorenzo.pieralisi at arm.com>
> Cc: Bjorn Helgaas <bhelgaas at google.com>
> Cc: Russell King <linux at armlinux.org.uk>
> Cc: linux-pci at vger.kernel.org
> Cc: linux-arm-kernel at lists.infradead.org
> Signed-off-by: Rob Herring <robh at kernel.org>

Without this patch, 5.9.1 won't find the eMMC card on Clearfog Base for me, 
so:

Tested-by: Jan Kundrát <jan.kundrat at cesnet.cz>

Thanks for the fix,
Jan



More information about the linux-arm-kernel mailing list