[RFC][PATCH] drm/bridge: lvds-codec: Add support for pixel data sampling edge select

[Marek Vasut]

On 10/19/20 2:54 AM, Laurent Pinchart wrote:
> Hi Marek,

Hi,

> Thank you for the patch.
> 
> On Sat, Oct 03, 2020 at 01:08:23AM +0200, Marek Vasut wrote:
>> The OnSemi FIN3385 Parallel-to-LVDS encoder has a dedicated input line to
>> select input pixel data sampling edge. Add DT property "pixelclk-active",
>> same as the one used by display timings, and configure bus flags based on
>> this DT property.
> 
> The feature looks good to me. I however wonder if we shouldn't use the
> standard pclk-sample endpoint property (documented in [1]) instead of a
> custom properly.

Either is fine by me, but I think pixelclk-active, which comes from
panel-timings.yaml is closer to the video than multimedia bindings.
(the multimedia and video bindings should be aligned, sigh)

> The DT bindings for the lvds-codec should be updated accordingly. And
> the property should only be taken into account when operating in encoder
> mode, as for decoder mode there's no polarity for the sampling of LVDS
> signals, as you've explained in a reply to Sam.

So, we need to rework the whole compatible data and identify what is
encoder/decoder in addition to connector there.