[RFC PATCH 3/3] arm64: stacktrace: Implement reliable stacktrace

Mark Brown broonie at kernel.org
Fri Oct 16 08:30:50 EDT 2020


On Fri, Oct 16, 2020 at 12:13:14PM +0200, Miroslav Benes wrote:
> On Thu, 15 Oct 2020, Mark Brown wrote:
> > On Thu, Oct 15, 2020 at 03:33:44PM +0200, Miroslav Benes wrote:

> > > I think it would be nice to check if frame.pc is a valid text address here
> > > before it is consumed next.

> > I'm wondering if it might be better to do have the generic code do this
> > in consume_entry() or something, it doesn't seem arch specific?

> Maybe. There is currently no special consume_entry() for the reliable 
> interface, but I think there is no reason not to introduce one.

...[Existing implementations handle it]...

> So I don't know if it is worth it.

My thinking was that it's not a huge cost even if it's redundant for the
existing implementations and it's one less thing that people could miss.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20201016/ecbc4fa1/attachment.sig>


More information about the linux-arm-kernel mailing list