[patch 08/12] usb: hosts: Remove in_interrupt() from comments

Krzysztof Kozlowski krzk at kernel.org
Wed Oct 14 11:24:33 EDT 2020


On Wed, Oct 14, 2020 at 04:52:23PM +0200, Thomas Gleixner wrote:
> From: Ahmed S. Darwish <a.darwish at linutronix.de>
> 
> The usage of in_interrupt() in drivers is phased out for various reasons.
> 
> Various comments use !in_interrupt() to describe calling context for probe()
> and remove() functions. That's wrong because the calling context has to be
> preemptible task context, which is not what !in_interrupt() describes.
> 
> Cleanup the comments. While at it add the missing kernel doc argument
> descriptors and make usb_hcd_msp_remove() static.
> 
> Signed-off-by: Ahmed S. Darwish <a.darwish at linutronix.de>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy at linutronix.de>
> Signed-off-by: Thomas Gleixner <tglx at linutronix.de>
> Cc: Alan Stern <stern at rowland.harvard.edu>
> Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> Cc: linux-usb at vger.kernel.org
> Cc: linux-omap at vger.kernel.org
> Cc: Kukjin Kim <kgene at kernel.org>
> Cc: Krzysztof Kozlowski <krzk at kernel.org>
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: linux-samsung-soc at vger.kernel.org
> 
> ---
>  drivers/usb/host/ehci-fsl.c     |    9 ++++-----
>  drivers/usb/host/ehci-pmcmsp.c  |   15 +++++++++------
>  drivers/usb/host/ohci-at91.c    |   11 ++++++++---
>  drivers/usb/host/ohci-omap.c    |    7 ++++---
>  drivers/usb/host/ohci-pxa27x.c  |   11 ++++++-----
>  drivers/usb/host/ohci-s3c2410.c |   12 ++++++------

For the s3c2410:
Acked-by: Krzysztof Kozlowski <krzk at kernel.org>

Best regards,
Krzysztof



More information about the linux-arm-kernel mailing list