[net-next PATCH v1] net: phy: Move of_mdio from drivers/of to drivers/net/mdio
Calvin Johnson
calvin.johnson at oss.nxp.com
Fri Oct 9 03:06:36 EDT 2020
Hi Florian,
On Thu, Oct 08, 2020 at 07:26:44PM -0700, Florian Fainelli wrote:
>
>
> On 10/8/2020 7:20 PM, Calvin Johnson wrote:
> > Hi Rob,
> >
> > On Thu, Oct 08, 2020 at 11:35:07AM -0500, Rob Herring wrote:
> > > On Thu, Oct 8, 2020 at 9:47 AM Calvin Johnson
> > > <calvin.johnson at oss.nxp.com> wrote:
> > > >
> > > > Better place for of_mdio.c is drivers/net/mdio.
> > > > Move of_mdio.c from drivers/of to drivers/net/mdio
> > >
> > > One thing off my todo list. I'd started this ages ago[1].
> > >
> > > >
> > > > Signed-off-by: Calvin Johnson <calvin.johnson at oss.nxp.com>
> > > > ---
> > > >
> > > > MAINTAINERS | 2 +-
> > > > drivers/net/mdio/Kconfig | 8 ++++++++
> > > > drivers/net/mdio/Makefile | 2 ++
> > > > drivers/{of => net/mdio}/of_mdio.c | 0
> > > > drivers/of/Kconfig | 7 -------
> > > > drivers/of/Makefile | 1 -
> > > > 6 files changed, 11 insertions(+), 9 deletions(-)
> > > > rename drivers/{of => net/mdio}/of_mdio.c (100%)
> > >
> > > of_mdio.c is really a combination of mdio and phylib functions, so it
> > > should be split up IMO. With that, I think you can get rid of
> > > CONFIG_OF_MDIO. See my branch[1] for what I had in mind. But that can
> > > be done after this if the net maintainers prefer.
> > >
> > > Acked-by: Rob Herring <robh at kernel.org>
> > >
> > > Rob
> > >
> > > [1] git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git dt/move-net
> >
> > Makes sense to me to split of_mdio.c. I can work on it once my current task
> > completes.
>
> If you could take Rob's patches, given then a round of randconfig build
> tests and update the MAINTAINERS file (no more drivers/of/of_mdio.c), then
> this looks like the right approach to me. Thanks!
I gave a quick try with those patches and it needs some more work to apply
as they are bit old. I can look into this later afer the ACPI work is done.
For now, this patch is good to merge as I've done some sanity.
Thanks
Calvin
More information about the linux-arm-kernel
mailing list