[PATCH] i2c: pxa: move to generic GPIO recovery

Codrin.Ciubotariu at microchip.com Codrin.Ciubotariu at microchip.com
Sat Oct 3 18:46:13 EDT 2020


>>   static void i2c_pxa_unprepare_recovery(struct i2c_adapter *adap)
>> @@ -1325,8 +1320,6 @@ static void i2c_pxa_unprepare_recovery(struct i2c_adapter *adap)
>>                i2c_pxa_do_reset(i2c);
>>        }
>>
>> -     WARN_ON(pinctrl_select_state(i2c->pinctrl, i2c->pinctrl_default));
>> -
> 
> This won't fly. We need to put the pinctrl back into i2c mode _before_
> we re-enable the I2C module, otherwise the I2C block will see logic 0
> on both SCL and SDA which could confuse the block.

Right, I will add it back.

Best regards,
Codrin


More information about the linux-arm-kernel mailing list