[PATCH 1/2] perf: arm-cmn: Fix unsigned comparison to less than zero

[Gustavo A. R. Silva]

On Thu, Oct 01, 2020 at 12:03:14PM +0100, Will Deacon wrote:
> Ensure that the 'irq' field of 'struct arm_cmn_dtc' is a signed int
> so that it can be compared '< 0'.
> 
> Link: https://lore.kernel.org/r/20200929170835.GA15956@embeddedor
> Addresses-Coverity-ID: 1497488 ("Unsigned compared against 0")
> Fixes: 0ba64770a2f2 ("perf: Add Arm CMN-600 PMU driver")
> Reported-by: Gustavo A. R. Silva <gustavoars at kernel.org>
> Signed-off-by: Will Deacon <will at kernel.org>

Reviewed-by: Gustavo A. R. Silva <gustavoars at kernel.org>

Thanks
--
Gustavo

> ---
>  drivers/perf/arm-cmn.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/perf/arm-cmn.c b/drivers/perf/arm-cmn.c
> index e824b5b83ea2..cd4da4c5dac0 100644
> --- a/drivers/perf/arm-cmn.c
> +++ b/drivers/perf/arm-cmn.c
> @@ -217,7 +217,7 @@ struct arm_cmn_node {
>  
>  struct arm_cmn_dtc {
>  	void __iomem *base;
> -	unsigned int irq;
> +	int irq;
>  	int irq_friend;
>  	bool cc_active;
>  
> -- 
> 2.28.0.709.gb0816b6eb0-goog
>