[PATCH v2 08/12] ARM: dts: imx6dl-pico: fix board compatibles

[Ahmad Fatoum]

Hi,

On 10/1/20 9:32 AM, Krzysztof Kozlowski wrote:
> On Thu, Oct 01, 2020 at 09:22:03AM +0200, Ahmad Fatoum wrote:
>>> diff --git a/arch/arm/boot/dts/imx6dl-pico-hobbit.dts b/arch/arm/boot/dts/imx6dl-pico-hobbit.dts
>>> index d7403c5c4337..08fedcbcc91b 100644
>>> --- a/arch/arm/boot/dts/imx6dl-pico-hobbit.dts
>>> +++ b/arch/arm/boot/dts/imx6dl-pico-hobbit.dts
>>> @@ -13,5 +13,5 @@
>>>  
>>>  / {
>>>  	model = "TechNexion PICO-IMX6 DualLite/Solo Board and Hobbit baseboard";
>>> -	compatible = "technexion,imx6dl-pico", "fsl,imx6dl";
>>> +	compatible = "technexion,imx6dl-pico-hobbit", "fsl,imx6dl";
>>>  };
> 
> The bindings, added in commit 53b61224ca40 ("dt-bindings: arm: fsl: Add
> TechNexion boards"), describe that these are the only valid compatibles.
> "technexion,imx6dl-pico" is not valid and would require changing the
> bindings, thus breaking compatibility which you want to avoid.> 
> The bindings, not what is present in DTS, is considered ABI.

The existing binding doesn't cover these boards then and needs to be
extended, no? How about following patch?

[I guess we need to keep the two-compatible list they were originally
 in for compatibility even if it's unused among upstream device trees?]

Cheers,
Ahmad

-------------------------8<---------------------------

>From d2e44951f900a1774ef289db22812969e72925d6 Mon Sep 17 00:00:00 2001
From: Ahmad Fatoum <a.fatoum at pengutronix.de>
Date: Thu, 1 Oct 2020 12:03:36 +0200
Subject: [RFC PATCH] dt-bindings: arm: fsl: add technexion,imx6dl-pico compatible

The technexion,imx6dl-pico -dwarf, -hobbit, -nymph and -pi all use the
same SoM. Reflect this compatibility with the SoM in the binding.

Signed-off-by: Ahmad Fatoum <a.fatoum at pengutronix.de>
---
 Documentation/devicetree/bindings/arm/fsl.yaml | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 6da9d734cdb7..b7110305ce81 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -211,6 +211,16 @@ properties:
           - const: gw,ventana
           - const: fsl,imx6dl
 
+      - description: i.MX6DL TechNexion Pico Boards
+        items:
+          - enum:
+              - technexion,imx6dl-pico-dwarf   # TechNexion i.MX6DL Pico-Dwarf
+              - technexion,imx6dl-pico-hobbit  # TechNexion i.MX6DL Pico-Hobbit
+              - technexion,imx6dl-pico-nymph   # TechNexion i.MX6DL Pico-Nymph
+              - technexion,imx6dl-pico-pi      # TechNexion i.MX6DL Pico-Pi
+          - const: technexion,imx6dl-pico
+          - const: fsl,imx6dl
+
       - description: i.MX6SL based Boards
         items:
           - enum:


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |