question: interconnect: changes in 5.10 / imx8mq ?

[Georgi Djakov]

On 30.11.20 22:34, Martin Kepplinger wrote:
> hi,
> 
> what I've used on v5.9 on imx8mq in order to hook up dram frequency to 
> interconnect (via mxsfb/lcdif) - and has worked fine - is:
> 
> * add the NOC node description with "#interconnect-cells = <1>;"
> https://source.puri.sm/martin.kepplinger/linux-next/-/commit/8a6b8486a3e94e2886bde01000f9532e03d243a4 
> 
> (original author is Leonard. I'll preserve authorship when submitting)
> 
> * add "interconnects = <&noc IMX8MQ_ICM_LCDIF &noc IMX8MQ_ICS_DRAM>;
> " to lcdif:
> https://source.puri.sm/martin.kepplinger/linux-next/-/commit/6c4bbcdc315da01a9dc8bbda36290587ce1ed33a 
[..]
> 
>   node                                  tag          avg         peak
> --------------------------------------------------------------------
> NOC                                          2147483647   2147483647
>    30320000.lcd-controller                0            0            0
> DRAM                                         2147483647   2147483647
>    30320000.lcd-controller                0            0            0
> (...)
> 
> 
> 
> what am I doing wrong on recent kernels?

Hi Martin,
This looks related to sync_state. Please try the change below.
It would be nice to get these DT patches merged into mainline.

Thanks,
Georgi

diff --git a/drivers/interconnect/imx/imx8mq.c 
b/drivers/interconnect/imx/imx8mq.c
index ba43a15aefec..9bb951b075e9 100644
--- a/drivers/interconnect/imx/imx8mq.c
+++ b/drivers/interconnect/imx/imx8mq.c
@@ -94,6 +94,7 @@ static struct platform_driver imx8mq_icc_driver = {
  	.remove = imx8mq_icc_remove,
  	.driver = {
  		.name = "imx8mq-interconnect",
+		.sync_state = icc_sync_state,
  	},
  };