[PATCH] __div64_32(): straighten up inline asm constraints

Nicolas Pitre nico at fluxnic.net
Mon Nov 30 15:27:20 EST 2020


On Mon, 30 Nov 2020, Nick Desaulniers wrote:

> On Mon, Nov 30, 2020 at 11:05 AM Nicolas Pitre <nico at fluxnic.net> wrote:
> 
> > +       __rem = __n >> 32;
> >         *n = __res;
> >         return __rem;
> 
> The above 3 statement could be:
> 
> ```
> *n = __res;
> return __n >> 32;
> ```

They could. However the compiler doesn't care, and the extra line makes 
it more obvious that the reminder is the high part of __n. So, 
semantically the extra line has value.

Thanks for the review.


Nicolas



More information about the linux-arm-kernel mailing list