[linux-sunxi] [PATCH 2/3] ARM: dts: sun8i: v3s: enable EHCI/OHCI for Lichee Pi Zero

[Chen-Yu Tsai]

On Mon, Nov 23, 2020 at 6:22 PM Icenowy Zheng <icenowy at aosc.io> wrote:
>
>
>
> 于 2020年11月23日 GMT+08:00 上午11:37:43, Chen-Yu Tsai <wens at csie.org> 写到:
> >On Sun, Nov 22, 2020 at 8:40 AM Icenowy Zheng <icenowy at aosc.io> wrote:
> >>
> >> As the USB port on Lichee Pi Zero works in the OTG mode, enable the
> >> EHCI/OHCI controllers for it.
> >
> >You should probably mention that the host controllers work better
> >than the OTG controller in host mode. Otherwise this change lacks
> >justification for enabling two extra hardware blocks.
>
> Our PHY driver do not sense whether ?HCI is enabled or not, so
> for host to work it's necessary to be enabled, otherwise the phy
> driver will just route USB to unenabled ?HCI and fail.

So, this was never working in Linux to begin with? You should mention that.

Maybe a fixes tag is in order then.