[PATCH] bus: sunxi-rsb: make remove callback return void

Lee Jones lee.jones at linaro.org
Thu Nov 26 03:03:16 EST 2020


On Thu, 26 Nov 2020, Chen-Yu Tsai wrote:

> On Thu, Nov 26, 2020 at 3:41 PM Uwe Kleine-König
> <u.kleine-koenig at pengutronix.de> wrote:
> >
> > The driver core ignores the return value of struct device_driver::remove
> > because there is only little that can be done. To simplify the quest to
> > make this function return void, let struct sunxi_rsb_driver::remove
> > return void, too. All users already unconditionally return 0, this
> > commit makes this obvious and ensures future users don't behave
> > differently. To simplify even further, make axp20x_device_remove()
> > return void instead of returning 0 unconditionally, too.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> 
> Looks good to me.
> 
> Reviewed-by: Chen-Yu Tsai <wens at csie.org>
> 
> Since this touches the mfd tree as well, we either need an Ack from Lee,
> the mfd maintainer (CC-ed), or let Lee take it in his tree. For the latter,

Right.  Thank you Chen-Yu.

Uwe, did you run get_maintainer.pl?

Please re-submit this with the proper people on Cc.

> Acked-by: Chen-Yu Tsai <wens at csie.org>
> 
> AFAIK we (sunxi) don't have anything regarding RSB queued up, so there
> won't be any conflicts.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog



More information about the linux-arm-kernel mailing list