[RFC PATCH] clk: imx8qxp: Unbreak auto module building for MXC_CLK_SCU

Aisheng Dong aisheng.dong at nxp.com
Wed Nov 25 06:08:38 EST 2020


Hi Sebastian

> From: Aisheng Dong <aisheng.dong at nxp.com>
> Sent: Wednesday, November 25, 2020 5:53 PM
> 
> > From: Sebastian Andrzej Siewior <bigeasy at linutronix.de>
> > Sent: Wednesday, November 25, 2020 4:40 PM
> >
> > On 2020-11-25 07:15:24 [+0000], Aisheng Dong wrote:
> > > I think the simplest solution is make MXC_CLK_SCU to be invisible to
> > > users and can only be selected by CLK_IMX8QXP option because
> > > currently clk-scu.o and clk-imx8qxp.o are built together, it's
> > > meaningless and buggy to separate them. Longtermly they will be combined
> into one driver file.
> > >
> > > E.g
> > > diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig index
> > > 3b393cb07295..dbacdd70af2e 100644
> > > --- a/drivers/clk/imx/Kconfig
> > > +++ b/drivers/clk/imx/Kconfig
> > > @@ -5,7 +5,7 @@ config MXC_CLK
> > >         depends on ARCH_MXC || COMPILE_TEST
> > >
> > >  config MXC_CLK_SCU
> > > -       tristate "IMX SCU clock"
> > > +       tristate
> > >         depends on ARCH_MXC || COMPILE_TEST
> > >         depends on IMX_SCU && HAVE_ARM_SMCCC
> >
> > So it still becomes a module if it gets selected by one, like CLK_IMX8QXP.
> >
> 
> Yes, as MXC_CLK_SCU and CLK_IMX8QXP will be enabled at the same time and
> clk-scu.o and clk-imx8qxp.o are compiled together into one module, there will
> be no such issues reported in this email.
> 
> 
> > > See fixes here:
> ...
> >
> > Whatever you do, please make sure the issue in v5.10 gets also addressed.
> 
> Will you send out above patch if you're ok?
> Or I will do it now if you don't mind.

I just sent out the fix with you CCed.

Regards
Aisheng

> 
> Regards
> Aisheng
> 
> >
> > Sebastian


More information about the linux-arm-kernel mailing list