[RFC PATCH] clk: imx8qxp: Unbreak auto module building for MXC_CLK_SCU

Sebastian Andrzej Siewior bigeasy at linutronix.de
Wed Nov 25 03:40:07 EST 2020


On 2020-11-25 07:15:24 [+0000], Aisheng Dong wrote:
> I think the simplest solution is make MXC_CLK_SCU to be invisible to users and can only
> be selected by CLK_IMX8QXP option because currently clk-scu.o and clk-imx8qxp.o are built
> together, it's meaningless and buggy to separate them. Longtermly they will be combined into
> one driver file.
> 
> E.g
> diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig
> index 3b393cb07295..dbacdd70af2e 100644
> --- a/drivers/clk/imx/Kconfig
> +++ b/drivers/clk/imx/Kconfig
> @@ -5,7 +5,7 @@ config MXC_CLK
>         depends on ARCH_MXC || COMPILE_TEST
>  
>  config MXC_CLK_SCU
> -       tristate "IMX SCU clock"
> +       tristate
>         depends on ARCH_MXC || COMPILE_TEST
>         depends on IMX_SCU && HAVE_ARM_SMCCC

So it still becomes a module if it gets selected by one, like
CLK_IMX8QXP.

> See fixes here:
> https://patchwork.kernel.org/project/linux-clk/cover/20201124100802.22775-1-aisheng.dong@nxp.com/

Whatever you do, please make sure the issue in v5.10 gets also addressed.

Sebastian



More information about the linux-arm-kernel mailing list