[PATCH 1/1] clk: imx: scu: remove the calling of device_is_bound

Aisheng Dong aisheng.dong at nxp.com
Tue Nov 24 05:28:00 EST 2020


> From: Sudip Mukherjee <sudipm.mukherjee at gmail.com>
> Sent: Friday, November 20, 2020 1:45 AM
> On Thu, Nov 19, 2020 at 3:30 PM Aisheng Dong <aisheng.dong at nxp.com>
> wrote:
> >
> > > From: Sudip Mukherjee <sudipm.mukherjee at gmail.com>
> > > Sent: Thursday, November 19, 2020 9:08 PM
> > >
> > > Hi Dong,
> > >
> > > On Thu, Nov 19, 2020 at 07:43:02PM +0800, Dong Aisheng wrote:
> > > > The device_is_bound() is unvisable to drivers when built as modules.
> > > > It's also not aimed to be used by drivers according to Greg K.H.
> > > > Let's remove it from clk-scu driver and find another way to do
> > > > proper driver loading sequence.
> > >
> > > Greg was asking to use device_link for this issue. Have you tried
> > > something like the following: (untested as I dont have the hardware).
> >
> > It can't work as expected because it requires supplier devices (scu pd) to be
> probed first.
> > and if scu pd was probed first, then there're already no issues.
> 
> hmm.. thats odd. I was expecting that if "scu-pd" has not registered then
> device_link_add() will return NULL and then imx_clk_scu_init() will return
> -EPROBE_DEFER.

The problem is what if scu-pd has registered but not probed. The device _link_add
won't block the scu clk to continue to run while scu_pd driver is still not ready.
This is not as expected.

Regards
Aisheng


> 
> 
> --
> Regards
> Sudip


More information about the linux-arm-kernel mailing list