[PATCH v6 5/5] regulator: add SCMI driver

Mark Brown broonie at kernel.org
Mon Nov 23 14:10:57 EST 2020


On Mon, Nov 23, 2020 at 06:49:56PM +0000, Cristian Marussi wrote:
> On Mon, Nov 23, 2020 at 05:49:41PM +0000, Mark Brown wrote:
> > On Thu, Nov 19, 2020 at 07:10:51PM +0000, Cristian Marussi wrote:

> > > +	rinfo->num_doms = num_doms;
> > > +	/*

> > Several places like this with missing blank lines.

> What do you mean ? a blank before the comment ?
> Sorry but checkpatch --strict does not complain, I was not aware of
> this styling. I'll do (if you confirm that's what you want)

Yes, a blank line between separate semantic blocks.  This is normal
coding style for the kernel, while checkpatch being a very simple script
can't detect it it's surprising that this seems surprising to you.

> How do you prefer these changes (and the DT one) ? 
> All as followup patches in a V7 series on top of
> sudeep/for-next/scmi-voltage ?

Incremental patches on top of what's applied.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20201123/8a7583ae/attachment.sig>


More information about the linux-arm-kernel mailing list