[linux-sunxi] Re: [PATCH] ARM: dts: sun7i: pcduino3-nano: enable RGMII RX/TX delay on PHY

Maxime Ripard maxime at cerno.tech
Mon Nov 23 06:48:56 EST 2020


Hi,

On Mon, Nov 23, 2020 at 12:42:54PM +0800, Chen-Yu Tsai wrote:
> On Mon, Oct 26, 2020 at 12:34 AM Andrew Lunn <andrew at lunn.ch> wrote:
> >
> > On Sun, Oct 25, 2020 at 02:01:44PM +0000, Adam Sampson wrote:
> > > The RX/TX delays for the Ethernet PHY on the Linksprite pcDuino 3 Nano
> > > are configured in hardware, using resistors that are populated to pull
> > > the RTL8211E's RXDLY/TXDLY pins low or high as needed.
> > >
> > > phy-mode should be set to rgmii-id to reflect this. Previously it was
> > > set to rgmii, which used to work but now results in the delays being
> > > disabled again as a result of the bugfix in commit bbc4d71d6354 ("net:
> > > phy: realtek: fix rtl8211e rx/tx delay config").
> > >
> > > Tested on two pcDuino 3 Nano boards purchased in 2015. Without this fix,
> > > Ethernet works unreliably on one board and doesn't work at all on the
> > > other.
> > >
> > > Fixes: 061035d456c9 ("ARM: dts: sun7i: Add dts file for pcDuino 3 Nano board")
> > > Signed-off-by: Adam Sampson <ats at offog.org>
> >
> > Reviewed-by: Andrew Lunn <andrew at lunn.ch>
> 
> Looks like none of the maintainers were listed in the recipients.
> 
> Acked-by: Chen-Yu Tsai <wens at csie.org>

Adam, can you resend that patch?

Maxime
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20201123/123bd350/attachment.sig>


More information about the linux-arm-kernel mailing list