[PATCH] mmc: mediatek: fix mem leak in msdc_drv_probe

Ulf Hansson ulf.hansson at linaro.org
Tue Nov 17 06:50:06 EST 2020


On Thu, 12 Nov 2020 at 09:27, Zheng Liang <zhengliang6 at huawei.com> wrote:
>
> It should use mmc_free_host to free mem in error patch of
> msdc_drv_probe.
>
> Reported-by: Hulk Robot <hulkci at huawei.com>
> Signed-off-by: Zheng Liang <zhengliang6 at huawei.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/mtk-sd.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index fc5ee5df91ad..eac7838e2dac 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -2504,8 +2504,10 @@ static int msdc_drv_probe(struct platform_device *pdev)
>
>         host->reset = devm_reset_control_get_optional_exclusive(&pdev->dev,
>                                                                 "hrst");
> -       if (IS_ERR(host->reset))
> -               return PTR_ERR(host->reset);
> +       if (IS_ERR(host->reset)) {
> +               ret = PTR_ERR(host->reset);
> +               goto host_free;
> +       }
>
>         host->irq = platform_get_irq(pdev, 0);
>         if (host->irq < 0) {
> --
> 2.17.1
>



More information about the linux-arm-kernel mailing list