[PATCH v2 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID

[Peng Fan]

> Subject: Re: [PATCH v2 1/4] dt-bindings: soc: imx8m: add DT Binding doc for
> soc unique ID
> 
> On Thu, Nov 05, 2020 at 03:26:26PM +0800, Alice Guo wrote:
> > Add DT Binding doc for the Unique ID of i.MX 8M series.
> >
> > Signed-off-by: Alice Guo <alice.guo at nxp.com>
> > ---
> >  .../devicetree/bindings/arm/fsl.yaml          | 33
> +++++++++++++++++++
> >  1 file changed, 33 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml
> b/Documentation/devicetree/bindings/arm/fsl.yaml
> > index e4db0f9ed664..0419f078502b 100644
> > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > @@ -901,6 +901,39 @@ properties:
> >                - fsl,s32v234-evb           # S32V234-EVB2
> Customer Evaluation Board
> >            - const: fsl,s32v234
> >
> > +  soc:
> > +    description:
> > +      i.MX8M Family SoC must provide a soc node in the root of the
> device tree,
> > +      representing the System-on-Chip since these test chips are rather
> complex.
> > +    type: object
> > +    properties:
> > +      compatible:
> > +        oneOf:
> > +          - items:
> > +              - const: fsl,imx8mm-soc
> > +              - const: simple-bus
> > +          - items:
> > +              - const: fsl,imx8mn-soc
> > +              - const: simple-bus
> > +          - items:
> > +              - const: fsl,imx8mp-soc
> > +              - const: simple-bus
> > +          - items:
> > +              - const: fsl,imx8mq-soc
> > +              - const: simple-bus
> 
> items:
>   - enum:
>       - fsl,imx8mm-soc
>       - fsl,imx8mn-soc
>       - fsl,imx8mp-soc
>       - fsl,imx8mq-soc
>   - const: simple-bus
> 
> > +
> > +      nvmem-cells:
> > +        maxItems: 1
> > +        description: Phandle to the SOC Unique ID provided by a nvmem
> node
> > +
> > +      nvmem-cells-names:
> > +        const: soc_unique_id
> > +
> > +    required:
> > +      - compatible
> > +      - nvmem-cells
> > +      - nvmem-cell-names
> > +
> 
> 'soc' should be required?

The fsl,imx8m[m,n,p,q] already used by root node compatible.
So here could reuse the same compatible string? Or
We add an extra 'soc' here?

Thanks,
Peng. 

> 
> >  additionalProperties: true
> >
> >  ...
> > --
> > 2.17.1
> >