[PATCH 4/6] arm64: dts: allwinner: pinephone: Add light/proximity sensor
Maxime Ripard
maxime at cerno.tech
Thu Nov 5 06:23:19 EST 2020
Hi,
On Wed, Nov 04, 2020 at 11:41:33PM -0600, Samuel Holland wrote:
> From: Ondrej Jirman <megous at megous.com>
>
> Pinephone has STK3311-X proximity sensor. Add support for it.
>
> Signed-off-by: Ondrej Jirman <megous at megous.com>
> Signed-off-by: Samuel Holland <samuel at sholland.org>
> ---
> .../arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> index e595a8262920..9544d7658794 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> @@ -160,6 +160,16 @@ lis3mdl: lis3mdl at 1e {
> vddio-supply = <®_dldo1>;
> };
>
> + /* Light/proximity sensor */
> + stk3311 at 48 {
> + compatible = "sensortek,stk3311";
> + reg = <0x48>;
> + interrupt-parent = <&pio>;
> + interrupts = <1 0 IRQ_TYPE_EDGE_FALLING>; /* PB0 */
> + vdd-supply = <®_ldo_io0>;
> + leda-supply = <®_dldo1>;
> + };
> +
The node names should be the class of the device, not the model. The
other sensors here have a similar issue though, so I've applied it, but
could you send a subsequent patch fixing this?
Thanks!
Maxime
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20201105/9a4449f9/attachment.sig>
More information about the linux-arm-kernel
mailing list