[PATCH 02/12] net: ethernet: smsc: smc911x: Mark 'status' as __maybe_unused

Andrew Lunn andrew at lunn.ch
Wed Nov 4 09:45:10 EST 2020


On Wed, Nov 04, 2020 at 02:31:40PM +0000, Lee Jones wrote:
> On Wed, 04 Nov 2020, Andrew Lunn wrote:
> 
> > On Wed, Nov 04, 2020 at 09:06:00AM +0000, Lee Jones wrote:
> > > 'status' is used to interact with a hardware register.  It might not
> > > be safe to remove it entirely.  Mark it as __maybe_unused instead.
> > 
> > Hi Lee
> > 
> > https://www.mail-archive.com/netdev@vger.kernel.org/msg365875.html
> > 
> > I'm working on driver/net/ethernet and net to make it w=1 clean.  I
> > suggest you hang out on the netdev mailing list so you don't waste
> > your time reproducing what i am doing.
> 
> I believe that ship has sailed.  Net should be clean now.

drivers/net is getting better, but is not clean. I have some patches
from Arnd which allow W=1 to be enabled by default for subdirectories,
and i have to skip a few. Also net, not driver/net has problems, which
i'm working on. I hope Arnd will post his patches soon, so we can get
them merged and prevent regressions with W=1.

> Maybe that was down to some of your previous efforts? 

And Jakub running a bot which compile tests all new patches with W=1.

    Andrew



More information about the linux-arm-kernel mailing list