[PATCH 08/12] net: xen-netfront: Demote non-kernel-doc headers to standard comment blocks

Jürgen Groß jgross at suse.com
Wed Nov 4 04:31:43 EST 2020


On 04.11.20 10:06, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>   drivers/net/xen-netfront.c: In function ‘store_rxbuf’:
>   drivers/net/xen-netfront.c:2416:16: warning: variable ‘target’ set but not used [-Wunused-but-set-variable]

Those two warnings are not fixed by the patch.

>   drivers/net/xen-netfront.c:1592: warning: Function parameter or member 'dev' not described in 'netfront_probe'
>   drivers/net/xen-netfront.c:1592: warning: Function parameter or member 'id' not described in 'netfront_probe'
>   drivers/net/xen-netfront.c:1669: warning: Function parameter or member 'dev' not described in 'netfront_resume'
>   drivers/net/xen-netfront.c:2313: warning: Function parameter or member 'dev' not described in 'netback_changed'
>   drivers/net/xen-netfront.c:2313: warning: Function parameter or member 'backend_state' not described in 'netback_changed'
> 
> Cc: Boris Ostrovsky <boris.ostrovsky at oracle.com>
> Cc: Juergen Gross <jgross at suse.com>
> Cc: Stefano Stabellini <sstabellini at kernel.org>
> Cc: "David S. Miller" <davem at davemloft.net>
> Cc: Jakub Kicinski <kuba at kernel.org>
> Cc: Alexei Starovoitov <ast at kernel.org>
> Cc: Daniel Borkmann <daniel at iogearbox.net>
> Cc: Jesper Dangaard Brouer <hawk at kernel.org>
> Cc: John Fastabend <john.fastabend at gmail.com>
> Cc: Martin KaFai Lau <kafai at fb.com>
> Cc: Song Liu <songliubraving at fb.com>
> Cc: Yonghong Song <yhs at fb.com>
> Cc: Andrii Nakryiko <andrii at kernel.org>
> Cc: KP Singh <kpsingh at chromium.org>
> Cc: xen-devel at lists.xenproject.org
> Cc: netdev at vger.kernel.org
> Cc: bpf at vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones at linaro.org>

With the commit message fixed you can have my:

Reviewed-by: Juergen Gross <jgross at suse.com>


Juergen



More information about the linux-arm-kernel mailing list