[PATCH] pwm: ab8500: Add error message if pwmchip_add() fails

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Tue Nov 3 03:00:39 EST 2020


On Mon, Oct 26, 2020 at 09:33:00AM +0000, Lee Jones wrote:
> On Thu, 22 Oct 2020, Uwe Kleine-König wrote:
> 
> > On Wed, Aug 12, 2020 at 09:11:39AM +0100, Lee Jones wrote:
> > > On Wed, 12 Aug 2020, Uwe Kleine-König wrote:
> > > 
> > > > pwmchip_add() doesn't emit an error message, so add one in the driver.
> > > 
> > > Maybe placing one there would be a good idea.
> > > 
> > > It would certainly cut down on a lot of superfluous strings.
> > 
> > Hmm, I'm not convinced. Do you want to work on that? If not I suggest to
> > still apply the patch as currently it is justified.
> 
> I haven't looked at implementing it.  Does it look difficult/

Probably it isn't, needs just some endurance to actually do it. (And I
won't invest that in the near future, also because I'm not convinced
that the result is beneficial.)

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20201103/0ab2764d/attachment.sig>


More information about the linux-arm-kernel mailing list