[PATCH 8/9] dt-bindings: arm: sunxi: Add SL631 with IMX179 bindings

[Paul Kocialkowski]

On Mon 02 Nov 20, 15:27, Maxime Ripard wrote:
> On Mon, Nov 02, 2020 at 11:33:40AM +0100, Paul Kocialkowski wrote:
> > Hi,
> > 
> > On Mon 02 Nov 20, 11:13, Maxime Ripard wrote:
> > > On Sat, Oct 31, 2020 at 07:21:36PM +0100, Paul Kocialkowski wrote:
> > > > Document the compatible strings for the SL631 Action Camera with IMX179.
> > > > 
> > > > Signed-off-by: Paul Kocialkowski <contact at paulk.fr>
> > > > ---
> > > >  Documentation/devicetree/bindings/arm/sunxi.yaml | 6 ++++++
> > > >  1 file changed, 6 insertions(+)
> > > > 
> > > > diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml
> > > > index afa00268c7db..0fa0c0b5d89f 100644
> > > > --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
> > > > +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
> > > > @@ -754,6 +754,12 @@ properties:
> > > >            - const: sinlinx,sina33
> > > >            - const: allwinner,sun8i-a33
> > > >  
> > > > +      - description: SL631 Action Camera with IMX179
> > > > +        items:
> > > > +          - const: unknown,sl631-imx179
> > > > +          - const: unknown,sl631
> > > > +          - const: allwinner,sun8i-v3
> > > > +
> > > 
> > > unknown is not a valid vendor (and you should explain why you picked
> > > that vendor name in the first place).
> > 
> > Ah right, it's not in the vendor prefixes. The rationale is that there is no
> > indication of what the vendor might be on the PCB. Should I maybe use
> > allwinner here?
> 
> You should mention it in the commit log for a start :)

Definitely.

> But yeah, we've used allwinner as a fallback for those cases so far.

Okay then, I'll go with that and add some explanation in the commit log.

Thanks for the review!

Cheers,

Paul

-- 
Developer of free digital technology and hardware support.

Website: https://www.paulk.fr/
Coding blog: https://code.paulk.fr/
Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20201102/f656873f/attachment.sig>