[PATCH 10/10] gpio: gpio-mlxbf2.c: Provide __releases() annotation to stop confusing Sparse

Asmaa Mnebhi Asmaa at mellanox.com
Tue Jun 30 10:18:59 EDT 2020

Reviewed-by: Asmaa Mnebhi <asmaa at mellanox.com>

Thank you.

-----Original Message-----
From: Lee Jones <lee.jones at linaro.org> 
Sent: Tuesday, June 30, 2020 9:34 AM
To: linus.walleij at linaro.org; bgolaszewski at baylibre.com
Cc: linux-arm-kernel at lists.infradead.org; linux-kernel at vger.kernel.org; linux-gpio at vger.kernel.org; Lee Jones <lee.jones at linaro.org>; Asmaa Mnebhi <Asmaa at mellanox.com>
Subject: [PATCH 10/10] gpio: gpio-mlxbf2.c: Provide __releases() annotation to stop confusing Sparse

Sparse cannot peer into other functions to see when and if locks are acquired and released, thus it simply warns that a 'context imbalance'
is detected instead.  Let's be kind to Sparse and let it know that this behaviour is intentional.

 drivers/gpio/gpio-mlxbf2.c:125:12: warning: context imbalance in 'mlxbf2_gpio_lock_acquire' - different lock contexts for basic block
 drivers/gpio/gpio-mlxbf2.c:151:13: warning: context imbalance in 'mlxbf2_gpio_lock_release' - unexpected unlock

Cc: Asmaa Mnebhi <Asmaa at mellanox.com>
Signed-off-by: Lee Jones <lee.jones at linaro.org>
 drivers/gpio/gpio-mlxbf2.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpio/gpio-mlxbf2.c b/drivers/gpio/gpio-mlxbf2.c index 861a8d0a84be0..befa5e1099439 100644
--- a/drivers/gpio/gpio-mlxbf2.c
+++ b/drivers/gpio/gpio-mlxbf2.c
@@ -149,6 +149,8 @@ static int mlxbf2_gpio_lock_acquire(struct mlxbf2_gpio_context *gs)
  * Release the YU arm_gpio_lock after changing the direction mode.
 static void mlxbf2_gpio_lock_release(struct mlxbf2_gpio_context *gs)
+	__releases(&gs->gc.bgpio_lock)
+	__releases(yu_arm_gpio_lock_param.lock)
 	writel(YU_ARM_GPIO_LOCK_RELEASE, yu_arm_gpio_lock_param.io);

More information about the linux-arm-kernel mailing list