[PATCH v7 1/3] iommu/arm-smmu: add NVIDIA implementation for dual ARM MMU-500 usage
jonathanh at nvidia.com
Tue Jun 30 06:23:30 EDT 2020
On 29/06/2020 23:49, Krishna Reddy wrote:
>>> + if (!nvidia_smmu->bases)
>>> + nvidia_smmu->bases = smmu->base;
>>> + return nvidia_smmu->bases[inst] + (page << smmu->pgshift); }
>> Not critical -- just a nit: why not put the bases in init()?
> smmu->base is not available during nvidia_smmu_impl_init() call. It is set afterwards in arm-smmu.c.
> It can't be avoided without changing the devm_ioremap() and impl_init() call order in arm-smmu.c.
Why don't we move the call to devm_ioremap_resource() to before
arm_smmu_impl_init() in arm_smmu_device_probe()? From a quick look I
don't see why we cannot do this and seems better than what we are
currently doing which is quite confusing and hard to understand.
More information about the linux-arm-kernel