[PATCH 2/4] pwm: bcm-kona: Remove impossible comparison when validating duty cycle

[Uwe Kleine-König]

On Mon, Jun 29, 2020 at 09:45:31AM -0700, Florian Fainelli wrote:
> 
> 
> On 6/29/2020 5:47 AM, Lee Jones wrote:
> > 'dc' here is an unsigned long, thus checking for <0 will always
> > evaluate to false.
> > 
> > Fixes the following W=1 warning:
> > 
> >  drivers/pwm/pwm-bcm-kona.c:141:35: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
> > 
> > Cc: Florian Fainelli <f.fainelli at gmail.com>
> > Cc: Ray Jui <rjui at broadcom.com>
> > Cc: Scott Branden <sbranden at broadcom.com>
> > Cc: bcm-kernel-feedback-list at broadcom.com
> > Cc: linux-pwm at vger.kernel.org
> > Signed-off-by: Lee Jones <lee.jones at linaro.org>
> 
> And similar to patch #1, DUTY_CYCLE_HIGH_MIN now gets unused, so if you
> remove it as well, you can add:
> 
> Reviewed-by: Florian Fainelli <f.fainelli at gmail.com>

Even without removing DUTY_CYCLE_HIGH_MIN (which might still serve as
documentation):

Acked-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20200629/b6d0b1eb/attachment.sig>