[PATCH v2 02/10] net: ethernet: ixgbe: don't call devm_mdiobus_free()

[Kirsher, Jeffrey T]

> -----Original Message-----
> From: Bartosz Golaszewski <brgl at bgdev.pl>
> Sent: Monday, June 29, 2020 05:04
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher at intel.com>; David S . Miller
> <davem at davemloft.net>; Jakub Kicinski <kuba at kernel.org>; John Crispin
> <john at phrozen.org>; Sean Wang <sean.wang at mediatek.com>; Mark Lee
> <Mark-MC.Lee at mediatek.com>; Matthias Brugger
> <matthias.bgg at gmail.com>; Heiner Kallweit <hkallweit1 at gmail.com>; Andrew
> Lunn <andrew at lunn.ch>; Florian Fainelli <f.fainelli at gmail.com>; Russell King
> <linux at armlinux.org.uk>; Rob Herring <robh+dt at kernel.org>; Frank Rowand
> <frowand.list at gmail.com>
> Cc: linux-kernel at vger.kernel.org; netdev at vger.kernel.org; linux-arm-
> kernel at lists.infradead.org; linux-mediatek at lists.infradead.org;
> devicetree at vger.kernel.org; Bartosz Golaszewski
> <bgolaszewski at baylibre.com>
> Subject: [PATCH v2 02/10] net: ethernet: ixgbe: don't call
> devm_mdiobus_free()
> 
> From: Bartosz Golaszewski <bgolaszewski at baylibre.com>
> 
> The idea behind devres is that the release callbacks are called if probe fails. As
> we now check the return value of ixgbe_mii_bus_init(), we can drop the call
> devm_mdiobus_free() in error path as the release callback will be called
> automatically.
> 
> Signed-off-by: Bartosz Golaszewski <bgolaszewski at baylibre.com>
 
Acked-by: Jeff Kirsher <jeffrey.t.kirsher at intel.com>

> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 14 +++-----------
>  1 file changed, 3 insertions(+), 11 deletions(-)