[PATCH 1/1] crypto: ux500: hash: Add namespacing to hash_init()

Linus Walleij linus.walleij at linaro.org
Mon Jun 29 09:58:02 EDT 2020

On Mon, Jun 29, 2020 at 2:30 PM Lee Jones <lee.jones at linaro.org> wrote:

> A recent change to the Regulator consumer API (which this driver
> utilises) add prototypes for the some suspend functions.  These
> functions require including header file include/linux/suspend.h.
> The following tree of includes affecting this driver will be
> present:
>    In file included from include/linux/elevator.h:6,
>                     from include/linux/blkdev.h:288,
>                     from include/linux/blk-cgroup.h:23,
>                     from include/linux/writeback.h:14,
>                     from include/linux/memcontrol.h:22,
>                     from include/linux/swap.h:9,
>                     from include/linux/suspend.h:5,
>                     from include/linux/regulator/consumer.h:35,
>                     from drivers/crypto/ux500/hash/hash_core.c:28:
> include/linux/elevator.h pulls in include/linux/hashtable.h which
> contains its own version of hash_init().  This confuses the build
> system and results in the following error (amongst others):
>  drivers/crypto/ux500/hash/hash_core.c:1362:19: error: passing argument 1 of '__hash_init' from incompatible pointer type [-Werror=incompatible-pointer-types]
>  1362 |  return hash_init(req);
> Fix this by namespacing the local hash_init() such that the
> source of confusion is removed.
> Cc: Linus Walleij <linus.walleij at linaro.org>
> Cc: Herbert Xu <herbert at gondor.apana.org.au>
> Cc: David S. Miller <davem at davemloft.net>
> Cc: linux-crypto at vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones at linaro.org>

This looks reasonable.
Reviewed-by: Linus Walleij <linus.walleij at linaro.org>

Linus Walleij

More information about the linux-arm-kernel mailing list