[PATCH 2/4] pwm: bcm-kona: Remove impossible comparison when validating duty cycle

Lee Jones lee.jones at linaro.org
Mon Jun 29 08:47:50 EDT 2020

'dc' here is an unsigned long, thus checking for <0 will always
evaluate to false.

Fixes the following W=1 warning:

 drivers/pwm/pwm-bcm-kona.c:141:35: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]

Cc: Florian Fainelli <f.fainelli at gmail.com>
Cc: Ray Jui <rjui at broadcom.com>
Cc: Scott Branden <sbranden at broadcom.com>
Cc: bcm-kernel-feedback-list at broadcom.com
Cc: linux-pwm at vger.kernel.org
Signed-off-by: Lee Jones <lee.jones at linaro.org>
 drivers/pwm/pwm-bcm-kona.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pwm/pwm-bcm-kona.c b/drivers/pwm/pwm-bcm-kona.c
index 81da91df2529a..16c5898b934a8 100644
--- a/drivers/pwm/pwm-bcm-kona.c
+++ b/drivers/pwm/pwm-bcm-kona.c
@@ -138,7 +138,7 @@ static int kona_pwmc_config(struct pwm_chip *chip, struct pwm_device *pwm,
 		dc = div64_u64(val, div);
 		/* If duty_ns or period_ns are not achievable then return */
+		if (pc < PERIOD_COUNT_MIN)
 			return -EINVAL;
 		/* If pc and dc are in bounds, the calculation is done */

More information about the linux-arm-kernel mailing list