usb: mtu3: Checking initialisation of the variable “mep” in two functions

Markus Elfring Markus.Elfring at
Sat Jun 27 08:28:50 EDT 2020


A source code analysis approach by the means of the semantic patch language
(Coccinelle software) pointed an implementation detail out for further
development considerations.

The functions “mtu3_gadget_ep_set_halt” and “mtu3_gadget_ep_set_wedge” check
at the beginning if the input parameter “ep” is a null pointer.
The error code “-EINVAL” will be returned then.

Can it be nicer to assign the variable “mep” only after a successful check
instead of an initialisation before?


More information about the linux-arm-kernel mailing list