[PATCH 1/3] irqchip/ti-sci-inta: Remove dead code in ti_sci_inta_set_type()

Grygorii Strashko grygorii.strashko at ti.com
Fri Jun 26 15:07:27 EDT 2020



On 06/06/2020 12:50, Tiezhu Yang wrote:
> In the function ti_sci_inta_set_type(), the statement "return -EINVAL;"
> out of switch case is dead code, remove it.
> 

Fixes: 9f1463b86c13 ("irqchip/ti-sci-inta: Add support for Interrupt Aggregator driver")
Right?

> Signed-off-by: Tiezhu Yang <yangtiezhu at loongson.cn>
> ---
>   drivers/irqchip/irq-ti-sci-inta.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-ti-sci-inta.c b/drivers/irqchip/irq-ti-sci-inta.c
> index 7e3ebf6..c20c9f7 100644
> --- a/drivers/irqchip/irq-ti-sci-inta.c
> +++ b/drivers/irqchip/irq-ti-sci-inta.c
> @@ -433,8 +433,6 @@ static int ti_sci_inta_set_type(struct irq_data *data, unsigned int type)
>   	default:
>   		return -EINVAL;
>   	}
> -
> -	return -EINVAL;
>   }
>   
>   static struct irq_chip ti_sci_inta_irq_chip = {
> 

For all 3 patches:
Reviewed-by: Grygorii Strashko <grygorii.strashko at ti.com>

And you might need re-send it with  --cover-letter
-- 
Best regards,
grygorii



More information about the linux-arm-kernel mailing list