[PATCH 07/10] misc: mic: vop: vop_main: Remove set but unused variable 'ret'

Arnd Bergmann arnd at arndb.de
Fri Jun 26 10:39:27 EDT 2020

On Fri, Jun 26, 2020 at 3:05 PM Lee Jones <lee.jones at linaro.org> wrote:
> Hasn't been checked since its conception 2 years ago.
> Squashes W=1 warning:
>  drivers/misc/mic/vop/vop_main.c: In function ‘_vop_scan_devices’:
>  drivers/misc/mic/vop/vop_main.c:617:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
>  617 | int ret;
>  | ^~~
> Cc: Sudeep Dutt <sudeep.dutt at intel.com>
> Cc: Ashutosh Dixit <ashutosh.dixit at intel.com>
> Cc: Christian Borntraeger <borntraeger at de.ibm.com>
> Signed-off-by: Lee Jones <lee.jones at linaro.org>

This is a correct change, but I'd take it one step further and make the
_vop_remove_device() function return 'void' if you don't mind
respinning the patch.

Either way

Acked-by: Arnd Bergmann <arnd at arndb.de>

More information about the linux-arm-kernel mailing list