[PATCH 01/10] misc: c2port: core: Ensure source size does not equal destination size in strncpy()
Rodolfo Giometti
giometti at enneenne.com
Fri Jun 26 09:15:43 EDT 2020
On 26/06/2020 15:05, Lee Jones wrote:
> We need to ensure there's a place for the NULL terminator.
>
> Fixes the following W=1 warning(s):
>
> In file included from include/linux/bitmap.h:9,
> from include/linux/nodemask.h:95,
> from include/linux/mmzone.h:17,
> from include/linux/gfp.h:6,
> from include/linux/umh.h:4,
> from include/linux/kmod.h:9,
> from include/linux/module.h:16,
> from drivers/misc/c2port/core.c:9:
> In function ‘strncpy’,
> inlined from ‘c2port_device_register’ at drivers/misc/c2port/core.c:926:2:
> include/linux/string.h:297:30: warning: ‘__builtin_strncpy’ specified bound 32 equals destination size [-Wstringop-truncation]
> 297 | #define __underlying_strncpy __builtin_strncpy
> | ^
> include/linux/string.h:307:9: note: in expansion of macro ‘__underlying_strncpy’
> 307 | return __underlying_strncpy(p, q, size);
> | ^~~~~~~~~~~~~~~~~~~~
>
> Cc: Rodolfo Giometti <giometti at linux.it>
> Cc: "Eurotech S.p.A" <info at eurotech.it>
> Signed-off-by: Lee Jones <lee.jones at linaro.org>
> ---
> drivers/misc/c2port/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/c2port/core.c b/drivers/misc/c2port/core.c
> index 33bba18022892..80d87e8a0bea9 100644
> --- a/drivers/misc/c2port/core.c
> +++ b/drivers/misc/c2port/core.c
> @@ -923,7 +923,7 @@ struct c2port_device *c2port_device_register(char *name,
> }
> dev_set_drvdata(c2dev->dev, c2dev);
>
> - strncpy(c2dev->name, name, C2PORT_NAME_LEN);
> + strncpy(c2dev->name, name, C2PORT_NAME_LEN - 1);
> c2dev->ops = ops;
> mutex_init(&c2dev->mutex);
>
Acked-by: Rodolfo Giometti <giometti at enneenne.com>
Note that giometti at linux.it is just an alias. My main e-mail address is
giometti at enneenne.com
Rodolfo Giometti
--
GNU/Linux Solutions e-mail: giometti at enneenne.com
Linux Device Driver giometti at linux.it
Embedded Systems phone: +39 349 2432127
UNIX programming skype: rodolfo.giometti
More information about the linux-arm-kernel
mailing list