[PATCH v2 2/2] ARM: dts: imx6q-tbs2910: Add an mdio node

Soeren Moch smoch at web.de
Thu Jun 25 12:29:25 EDT 2020


Hi Fabio,

On 25.06.20 13:18, Fabio Estevam wrote:
> imx6q-tbs2910 has an Atheros AR8035 Ethernet PHY at address 4.
>
> The AR8035 provides a 125MHz clock to the ENET_REF_CLK i.MX6 pin.
>
> Improve the Ethernet representation by adding an mdio node with such
> information.
>
> This fixes an Ethernet regression in U-Boot as U-Boot AR803X driver now
> expects the 'qca,clk-out-frequency' property to be passed via
> device tree.
>
> Signed-off-by: Fabio Estevam <festevam at gmail.com>
Due to my experience Shawn likes the properties sorted alphabetically,
with some exceptions.
I'm not sure if the "phy-handle" property is such exception.

But this works, describes the hardware correctly, and fixes ethernet
problems in U-Boot.

Reviewed-by: Soeren Moch <smoch at web.de>


Tested in U-Boot and linux-5.7:

Tested-by: Soeren Moch <smoch at web.de>

Thanks,
Soeren
> ---
> Changes since v1:
> - Use the correct board name in teh Subject.
>
>  arch/arm/boot/dts/imx6q-tbs2910.dts | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6q-tbs2910.dts b/arch/arm/boot/dts/imx6q-tbs2910.dts
> index 7b03b2787430..dfba19cd7af5 100644
> --- a/arch/arm/boot/dts/imx6q-tbs2910.dts
> +++ b/arch/arm/boot/dts/imx6q-tbs2910.dts
> @@ -101,7 +101,18 @@
>  	phy-mode = "rgmii-id";
>  	phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
>  	phy-reset-duration = <10>;
> +	phy-handle = <&phy>;
>  	status = "okay";
> +
> +	mdio {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		phy: ethernet-phy at 4 {
> +			reg = <4>;
> +			qca,clk-out-frequency = <125000000>;
> +		};
> +	};
>  };
>  
>  &hdmi {





More information about the linux-arm-kernel mailing list