[PATCH 03/50] staging: mmal-vchiq: Avoid use of bool in structures

Nicolas Saenz Julienne nsaenzjulienne at suse.de
Wed Jun 24 06:26:21 EDT 2020


On Tue, 2020-06-23 at 15:11 -0700, Joe Perches wrote:
> On Tue, 2020-06-23 at 18:41 +0200, Nicolas Saenz Julienne wrote:
> > From: Dave Stevenson <dave.stevenson at raspberrypi.org>
> > 
> > Fixes up a checkpatch error "Avoid using bool structure members
> > because of possible alignment issues".
> []
> > diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
> > b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
> []
> > @@ -1754,7 +1754,7 @@ int vchiq_mmal_component_enable(struct
> > vchiq_mmal_instance *instance,
> >  
> >  	ret = enable_component(instance, component);
> >  	if (ret == 0)
> > -		component->enabled = true;
> > +		component->enabled = 1;
> 
> This change does not match the commit description.
> 
> Also, checkpatch does not emit a warning here.

Fair enough I'll drop it for v2.

Regards,
Nicolas

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20200624/a092c25a/attachment.sig>


More information about the linux-arm-kernel mailing list