[EXT] Re: [PATCH v1] ARM: imx6plus: enable internal routing of clk_enet_ref where possible
fugang.duan at nxp.com
Tue Jun 23 23:46:24 EDT 2020
From: Sven Van Asbroeck <thesven73 at gmail.com> Sent: Wednesday, June 24, 2020 10:56 AM
> Hi Andy,
> On Tue, Jun 23, 2020 at 9:40 PM Andy Duan <fugang.duan at nxp.com> wrote:
> > The patch looks good.
> > Reviewed-by: Fugang Duan <fugang.duan at nxp.com>
> Thank you !
> To check we're on a plus, the patch uses:
> cpu_is_imx6q() && imx_get_soc_revision() >= IMX_CHIP_REVISION_2_0
> Fabio Estevam suggested that perhaps checking
> might be preferable. What is your opinion on this?
Yes, I also think of_machine_is_compatible() is much better.
More information about the linux-arm-kernel