[PATCH 0/3] pinctrl: single: support #pinctrl-cells = 2

Tony Lindgren tony at atomide.com
Mon Jun 22 12:11:32 EDT 2020

* Drew Fustini <drew at beagleboard.org> [200618 05:52]:
> Currently, pinctrl-single only allows #pinctrl-cells = 1.
> This series will allow pinctrl-single to also support #pinctrl-cells = 2
> If "pinctrl-single,pins" has 3 arguments (offset, conf, mux) then
> pcs_parse_one_pinctrl_entry() does an OR operation on to get the
> value to store in the register.
> To take advantage of #pinctrl-cells = 2, the AM33XX_PADCONF macro in
> omap.h is modified to keep pin conf and pin mux values separate.

Hmm to me it looks like the order of the patches is the
wrong way around here. Don't we need to first change
pinctrl-single.c, and then only after that update the
dts? And make sure the pinctrl-single.c change does not
break anything without changing the dts :)



More information about the linux-arm-kernel mailing list