[PATCH 1/1 v2] cpufreq: ap806: fix cpufreq driver needs ap cpu clk

[Viresh Kumar]

On 22-06-20, 11:17, Sven Auhagen wrote:
> On Mon, Jun 22, 2020 at 02:39:16PM +0530, Viresh Kumar wrote:
> > On 19-06-20, 10:21, Sven Auhagen wrote:
> > > The Armada 8K cpufreq driver needs the Armada AP CPU CLK
> > > to work. This dependency is currently not satisfied and
> > > the ARMADA_AP_CPU_CLK can not be selected independently.
> > > 
> > > Add it to the mvebu platform the same way the Armada 37XX CLK
> > > driver is enabled on the platform.
> > > 
> > > v2:
> > > * Resubmission without email footer
> > > 
> > > Signed-off-by: Sven Auhagen <sven.auhagen at voleatech.de>
> > > ---
> > >  arch/arm64/Kconfig.platforms | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> > > index 8dd05b2a925c..efb5355c9eea 100644
> > > --- a/arch/arm64/Kconfig.platforms
> > > +++ b/arch/arm64/Kconfig.platforms
> > > @@ -146,6 +146,7 @@ config ARCH_MVEBU
> > >  	bool "Marvell EBU SoC Family"
> > >  	select ARMADA_AP806_SYSCON
> > >  	select ARMADA_CP110_SYSCON
> > > +	select ARMADA_AP_CPU_CLK
> > 
> > What about adding a depends on in the cpufreq Kconfig for the driver instead ?
> 
> It is also an option. I went with this implementation because it was done the
> same way with the Armada 37XX and therefore it is more consistent.

I think that depends on is better as it lays out explicitly why the clk is
required. i.e. if cpufreq driver isn't compiled then the clk isn't needed. It is
far more readable then doing a select somewhere.

I will rather break consistency here for the sake of doing the right thing,
though we can convert earlier ones to do it properly as well.

-- 
viresh